Add data models and mappers for PDF report#3755
Open
andreia-ferreira wants to merge 15 commits into
Open
Conversation
…ng the user's 24h setting
andreia-ferreira
force-pushed
the
andreia/3739/formatters
branch
from
188b1e2 to
aaef86e
Compare
andreia-ferreira
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3755 +/- ##
============================================
- Coverage 68.06% 68.06% -0.01%
+ Complexity 1613 1612 -1
============================================
Files 368 369 +1
Lines 9528 9534 +6
Branches 1242 1244 +2
============================================
+ Hits 6485 6489 +4
- Misses 2376 2377 +1
- Partials 667 668 +1
🚀 New features to boost your workflow:
|
andreia-ferreira
requested a deployment
to
e2e-approval
GitHub Actions
Waiting
shobhitagarwal1612
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3739
In order to split up the PDF feature in different PRs, this one is focused on adding the platform-independent UI model
SubmissionPdfDocumentwhich represents the structure of the future PDF, as well as specific formatters (DateFormatter;NumberFormatter) and the mapperTaskValueMapperwhich are needed to present the data.This involved additional changes such as:
appto:core:ui. In order to make sure the multiplatform strings are valid a dedicated test was added for itComposeStringResourcesTestStringResolverwhich wraps Compose Multiplatform string resource resolution so that logic that uses resources can be easily unit tested without requiring a platform runtimetestAndroidHostTestto theRun unit testsstep of the CI, to make sure unit tests for specific android implementations in KMP modules are also run@shobhitagarwal1612 PTAL?